Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

what's so special about "check"? #27

Open
martinburch opened this issue Apr 8, 2022 · 1 comment
Open

what's so special about "check"? #27

martinburch opened this issue Apr 8, 2022 · 1 comment

Comments

@martinburch
Copy link

I thought since the id was check, changing the id to, say, lint, would allow changing

if: steps.check.outputs.triggered == 'true'
to
if: steps.lint.outputs.triggered == 'true'

however, this didn't work, steps.lint.outputs.triggered == 'true' never cause the next step to run

      - uses: khan/pull-request-comment-trigger@master
         id: lint
         with:
           trigger: '/lint'
           reaction: rocket
         env:
           GITHUB_TOKEN: '${{ secrets.GITHUB_TOKEN }}'
       - uses: yu-iskw/action-sqlfluff@v3
         if: steps.lint.outputs.triggered == 'true'

when I changed back to check everything worked as expected. Why is this? Doesn't really conform with the documentation here: https://docs.github.com/en/actions/learn-github-actions/contexts#steps-context which says you may access steps.<step_id>.outputs

@jaredly
Copy link
Contributor

jaredly commented May 5, 2022

hmm yeah that's not what I would expect either. Looks like maybe a bug in the github actions runner? I certainly haven't hardcoded "check" anywhere.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants