Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update require/import section of javascript.md #57

Open
kevinbarabash opened this issue Apr 6, 2017 · 3 comments
Open

update require/import section of javascript.md #57

kevinbarabash opened this issue Apr 6, 2017 · 3 comments

Comments

@kevinbarabash
Copy link
Contributor

  • remove sorting of require/import statements
  • blocks continues to be the same with the addition of a new block, flow type imports which should come last
  • prefer ES6 import syntax over require
  • destructuring should happen on the same line as the import, e.g. import React, {Component} from 'react'
@jlfwong
Copy link
Contributor

jlfwong commented Apr 7, 2017

:o did someone update kake to compile ES6 syntax?

@xymostech
Copy link
Contributor

@jlfwong I believe it always did, but the require-finding regexes got confused. :) @jeresig fixed that!

@jlfwong
Copy link
Contributor

jlfwong commented Apr 7, 2017

Yeah, that's what I meant :) Glad to hear the artificial restriction to the code I wrote long ago isn't holding anyone back :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants