Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow whole array operations for runtime-sized arrays? #167

Open
greg-lunarg opened this issue Aug 30, 2021 · 5 comments
Open

Disallow whole array operations for runtime-sized arrays? #167

greg-lunarg opened this issue Aug 30, 2021 · 5 comments

Comments

@greg-lunarg
Copy link

There currently is no language in the GLSL spec disallowing whole array operations for runtime-sized arrays. For an example, see KhronosGroup/glslang#2733.

SPIR-V virtually disallows these by disallowing an OpLoad of OpTypeRuntimearray. I presume that disallowing these in GLSL was an oversight.

Shall we proceed with creating a change to GLSL to disallow these?

@greg-lunarg
Copy link
Author

@gnl21 Which working group do we need approval from?

@laurie-hedge
Copy link

Imagination's GLSL ES compiler rejects whole array operations that involve a runtime-sized array with a compilation error. I would be in favour of codifying this behaviour in the spec.

@gnl21
Copy link
Contributor

gnl21 commented Sep 1, 2021

I think we primarily need approval from the GL working group, since GL implementations might have been accepting this (although we know that at least 2 weren't). It's scheduled to be discussed, so we should have an answer soon.

@pdaniell-nv pdaniell-nv added this to the Needs Action/PR milestone Sep 1, 2021
@gnl21
Copy link
Contributor

gnl21 commented Sep 1, 2021

The working group agrees that this should not be allowed. I'll make a change to the GLSL spec and it will be published in the next revision.

@dj2
Copy link
Contributor

dj2 commented Aug 25, 2024

This seems like it's clarified in the spec now, can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants