Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan reserved keywords are missing from the GLSL ES 3.2 Spec #212

Open
teoxoy opened this issue Jul 25, 2023 · 1 comment
Open

Vulkan reserved keywords are missing from the GLSL ES 3.2 Spec #212

teoxoy opened this issue Jul 25, 2023 · 1 comment
Assignees

Comments

@teoxoy
Copy link

teoxoy commented Jul 25, 2023

Comparing the GLSL 4.6 keywords with the GLSL ES 3.2 keywords, I noticed the following Vulkan keywords were missing from the GLSL ES 3.2 reserved keywords section.

texture1DArray
utexture2DRect
utexture1DArray
texture2DRect
texture1D
itexture1D
itexture1DArray
utexture1D
itexture2DRect

https://github.com/KhronosGroup/OpenGL-Registry/blob/d00e11dc1a1ffba581d633f21f70202051248d5c/specs/gl/GLSLangSpec.4.60.html#L2004-L2322

https://github.com/KhronosGroup/OpenGL-Registry/blob/d00e11dc1a1ffba581d633f21f70202051248d5c/specs/es/3.2/GLSL_ES_Specification_3.20.html#L2166-L2478

@pdaniell-nv pdaniell-nv transferred this issue from KhronosGroup/OpenGL-Registry Aug 1, 2023
@gnl21
Copy link
Contributor

gnl21 commented Aug 14, 2023

So these keywords are added by GL_KHR_vulkan_glsl to the desktop version of the spec, but they were not reserved before that extension in either GL or ES. The extension doesn't say what should happen to the 1D version of the keywords in ES, where 1D textures are not supported, but I agree that making them reserved would be the sensible thing to do. If the working group agrees then I'll update the spec.

@pdaniell-nv pdaniell-nv added this to the Needs Action/PR milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants