-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test to verify flush on clReleaseCommandQueue with multiple queues #2134
base: main
Are you sure you want to change the base?
Added test to verify flush on clReleaseCommandQueue with multiple queues #2134
Conversation
…en multiple dependent queues are used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kpet can you check that the test description in #2187 is correct?
This test follows the test description exactly (thanks!), but I would like to ensure it is properly testing that the flush happsn on clReleaseCommandQueue
and not somewhere else (e.g. the clFinish
).
bool success = poll_until(2000, 50, [&event_B]() { | ||
cl_int status; | ||
cl_int err = clGetEventInfo(event_B, CL_EVENT_COMMAND_EXECUTION_STATUS, | ||
sizeof(cl_int), &status, nullptr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we've called clFinish
on queue_B
here, the event_B
must already be CL_COMPLETE
.
@bashbaug I've reviewed the description and I think I still mostly agree with this. This won't prevent implementations from flushing queue A when Deadlocking is not a great failure mode for a test though so maybe we could call The following single queue test could be useful to have too:
|
Agree that clFlush on queue B rather than clFinish is more appropriate to prevent the test from deadlocking when the flush on clReleaseCommandQueue is missing. |
Fixes #2087 according to task description.