Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed usage of half types in CTS gl tests #2147

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Removed usage of half types in CTS gl tests #2147

merged 2 commits into from
Nov 26, 2024

Conversation

kamil-goras-mobica
Copy link
Contributor

@kamil-goras-mobica kamil-goras-mobica commented Nov 13, 2024 •
edited by bashbaug
Loading

see #1982

@kamil-goras-mobica kamil-goras-mobica mentioned this pull request Nov 13, 2024
Open
bashbaug
bashbaug previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great first step and we should merge this PR as-is.

I don't think we should close #1982 until we've looked at other uses of supportsHalf in these tests, though, since I think they have a similar problem.

test_conformance/gl/test_images_write_common.cpp Outdated Show resolved Hide resolved
@kamil-goras-mobica
Copy link
Contributor Author

kamil-goras-mobica commented Nov 14, 2024 •
edited
Loading

This is a great first step and we should merge this PR as-is.

I don't think we should close #1982 until we've looked at other uses of supportsHalf in these tests, though, since I think they have a similar problem.
@bashbaug
I saw in other files in gl directory that function supportsHalf() is used which is checking for cl_khr_fp16. I can take a look at them and create separate PR.

@bashbaug
Copy link
Contributor

I've edited the PR comment and I don't think it will automatically close #1982 anymore.

@bashbaug
Copy link
Contributor

Merging as discussed in the November 26th teleconference.

@bashbaug bashbaug merged commit feca4c6 into KhronosGroup:main Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug approved these changes

@lakshmih lakshmih lakshmih approved these changes

Assignees
No one assigned
Labels
focused review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamil-goras-mobica @bashbaug @lakshmih