Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected math_brute_force for cl_khr_fp16 tests sqrt and divide to use correctly rounded reference #2161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shajder
Copy link
Contributor

@shajder shajder commented Nov 26, 2024

Fixes #1996, fixes #2146 according to issue description

replaced function pointers related to generation reference values for
divide and sqrt in order to produce correctly rounded values
@shajder shajder marked this pull request as ready for review November 26, 2024 10:35
@svenvh
Copy link
Member

svenvh commented Nov 26, 2024

Just repeating what you already commented on #1996 and #2146: I'd like to understand what values are problematic before we merge this, as your experiments suggest we shouldn't need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants