Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed reciprocal test in math_brute_force #2162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removed reciprocal test in math_brute_force #2162

wants to merge 1 commit into from

Conversation

kamil-goras-mobica
Copy link
Contributor

Fixes #2145 according to description

@svenvh
Copy link
Member

svenvh commented Nov 26, 2024

1/x and x/y have different accuracy requirements under unsafe math optimizations; see Table 67 in Section 7.4. Are we covering that elsewhere or should we handle that in this reciprocal test?

@bashbaug
Copy link
Contributor

Are we covering that elsewhere or should we handle that in this reciprocal test?

I would also like to understand why this test can be removed vs. re-enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable reciprocal test in math_brute_force suite
3 participants
@kamil-goras-mobica @svenvh @bashbaug