New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do strings in the Windows resource file need a prefix #209

Open

bashbaug opened this issue Feb 22, 2023 · 1 comment

Contributor

bashbaug commented Feb 22, 2023

Found during a code review:
#206 (comment)

When looking at:
https://learn.microsoft.com/en-us/windows/win32/menurc/stringfileinfo-block
It seems that "040904E4" means that the values should be in U.S. English and in Multilingual character set (0x04E4 == 1252).
Thus shouldn't all the strings be prefixed by L here? Are we mixing character sets?

bashbaug mentioned this issue

Fix VERSIONINFO for llvm-rc #206

Merged

Contributor

mmuetzel commented Aug 23, 2023

CP1252 is a single byte character encoding:
https://en.wikipedia.org/wiki/Windows-1252

So, single byte string literals should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment