Add out-of-bounds assertions

tygyh · tygyh · commit fef81140de87 · 2024-11-12T19:01:56.000+01:00
diff --git a/spirv_cross_parsed_ir.cpp b/spirv_cross_parsed_ir.cpp
@@ -928,6 +928,8 @@ void ParsedIR::reset_all_of_type(Types type)
 
 void ParsedIR::add_typed_id(Types type, ID id)
 {
+	assert(id < ids.size());
+
 	if (loop_iteration_depth_hard != 0)
 		SPIRV_CROSS_THROW("Cannot add typed ID while looping over it.");
 
@@ -1030,6 +1032,8 @@ ParsedIR::LoopLock &ParsedIR::LoopLock::operator=(LoopLock &&other) SPIRV_CROSS_
 
 void ParsedIR::make_constant_null(uint32_t id, uint32_t type, bool add_to_typed_id_set)
 {
+	assert(id < ids.size());
+
 	auto &constant_type = get<SPIRType>(type);
 
 	if (constant_type.pointer)

Original file line number	Diff line number	Diff line change
`@@ -928,6 +928,8 @@ void ParsedIR::reset_all_of_type(Types type)`
`928`	`928`
`929`	`929`	`void ParsedIR::add_typed_id(Types type, ID id)`
`930`	`930`	`{`
	`931`	`+ assert(id < ids.size());`
	`932`	`+`
`931`	`933`	`if (loop_iteration_depth_hard != 0)`
`932`	`934`	`SPIRV_CROSS_THROW("Cannot add typed ID while looping over it.");`
`933`	`935`
`@@ -1030,6 +1032,8 @@ ParsedIR::LoopLock &ParsedIR::LoopLock::operator=(LoopLock &&other) SPIRV_CROSS_`
`1030`	`1032`
`1031`	`1033`	`void ParsedIR::make_constant_null(uint32_t id, uint32_t type, bool add_to_typed_id_set)`
`1032`	`1034`	`{`
	`1035`	`+ assert(id < ids.size());`
	`1036`	`+`
`1033`	`1037`	`auto &constant_type = get<SPIRType>(type);`
`1034`	`1038`
`1035`	`1039`	`if (constant_type.pointer)`