Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use spirv.h from the Vulkan SDK #115

Open
jesta88 opened this issue Feb 27, 2021 · 1 comment
Open

Use spirv.h from the Vulkan SDK #115

jesta88 opened this issue Feb 27, 2021 · 1 comment

Comments

@jesta88
Copy link

jesta88 commented Feb 27, 2021

If the project's dependency is the Vulkan SDK, why is the spirv.h copy needed?

If it's there to allow people to use spirv-reflect without the Vulkan SDK, it would still be nice to have the option to use the SDK's version through a define.
@jesta88 jesta88 changed the title Use spirv.h from the SDK Use spirv.h from the Vulkan SDK Feb 27, 2021
@chaoticbob
Copy link
Contributor

Totally fair point. The usage of spirv-reflect shouldn't depend on the Vulkan SDK but over the years this may have fallen through the cracks. I'll check.

I'll add an #ifdef to allow for the use of a custom spirv.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chaoticbob @jesta88