Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about support multiple OpSource in SpvReflectShaderModule? #116

Open
fromasmtodisasm opened this issue Mar 30, 2021 · 1 comment
Open

Comments

@fromasmtodisasm
Copy link

fromasmtodisasm commented Mar 30, 2021

At the moment, several embedded source files are incorrectly processed, each next one overwrites the previous one, which is not the desired behavior, this is also reflected in the API, GetSourceFile, it is assumed that there is only one include per source file when it is far from the truth. At least from the point of view of correct behavior, this is not permissible, I would like to see a complete list of included files.

From the point of view of the correctness of the API, it should at least look something like this:

  uint32_t                GetSourceFileCount() const;
  const char*           GetSourceFile(uint32_t  index) const;

this would correspond to the API of receiving an entry point:

  uint32_t                      GetEntryPointCount() const;
  const char*                   GetEntryPointName(uint32_t index) const;
@chaoticbob
Copy link
Contributor

Thanks, this is definitely a bug. Do you have a test case that you can share?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants