Crash handling SpvOpSourceContinued

[ccottrellnv]

On Windows systems, the handling of SpvOpSourceContinued will crash in the call to strcat_s in cases where both source_len and embedded_source_len are not zero. According to the strcat_s documentation:

“The behavior is undefined if the size of the character array pointed to by dest < strlen(dest)+strlen(src)+1 <= destsz”

In the case both source_len and embedded_source_len are not zero, the current code will have “destsz” < “strlen(dest)+strlen(src)+1”.

I think the code should read as follows:

        if (embedded_source_len) {
            strcpy_s(p_continued_source, embedded_source_len + 1, p_parser->source_embedded);
            strcat_s(p_continued_source, source_len + embedded_source_len + 1, p_source);
        }
        else {
            strcpy_s(p_continued_source, source_len + 1, p_source);
        }

It is also more correct to define embedded_source_len as follows:

const size_t embedded_source_len = p_parser->source_embedded ? strlen(p_parser->source_embedded) : 0;