Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VkSurfacePresentScalingCapabilitiesEXT incorrect usage description #2348

Open
tim-rex opened this issue Apr 10, 2024 · 2 comments
Open

VkSurfacePresentScalingCapabilitiesEXT incorrect usage description #2348

tim-rex opened this issue Apr 10, 2024 · 2 comments
Assignees

Comments

@tim-rex
Copy link

tim-rex commented Apr 10, 2024

The documentation for VkSurfacePresentScalingCapabilitiesEXT indicates:

Before creating a swapchain whose scaling mode can be specified through the use of VkSwapchainPresentScalingCreateInfoEXT, obtain the set of supported scaling modes by including a VkSurfacePresentModeEXT structure in the pNext chain of VkPhysicalDeviceSurfaceInfo2KHR when calling vkGetPhysicalDeviceSurfaceCapabilities2KHR.

That seems incorrect. The set of supported scaling modes is not contained within a VkSurfacePresentModeEXT struct.

I couldn't find any reference that correctly defines how to achieve this, but after some spelunking it seem this should in fact be:

VkSurfacePresentScalingCapabilitiesEXT

Before creating a swapchain whose scaling mode can be specified through the use of VkSwapchainPresentScalingCreateInfoEXT, obtain the set of supported scaling modes by including a VkSurfacePresentScalingCapabilitiesEXT structure in the pNext chain of VkSurfaceCapabilities2KHR when calling vkGetPhysicalDeviceSurfaceCapabilities2KHR.

@oddhack
Copy link
Contributor

oddhack commented Apr 10, 2024

@versalinyaa can you bring this up to SI TSG?

@stonesthrow
Copy link
Contributor

We did not have time for triage on this new item today.
The proposal in the description seems correct. A little verification is needed and text of spec updated to describe proper method is needed.
Thanks for raising issue and suggested clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants