Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the alignment of pOffsets passed to vkCmdBindVertexBuffers #2411

Open
godlikepanos opened this issue Aug 17, 2024 · 4 comments
Open
Assignees

Comments

@godlikepanos
Copy link

The documentation of vkCmdBindVertexBuffers doesn't mention something about the alignment of pOffsets. Not sure if the alignment requirements are mentioned in another section but I think it would be a good idea to have something as part of vkCmdBindVertexBuffers's documentation.

@HansKristian-Work
Copy link
Contributor

HansKristian-Work commented Aug 21, 2024

Alignment is validated after all vertex addressing logic has been applied, so it's too early to attempt validation at VBO bind time.

@godlikepanos
Copy link
Author

Right, true. I wonder if we can add some text that points to https://registry.khronos.org/vulkan/specs/1.1-extensions/html/vkspec.html#fxvertex-input-extraction for additional clarity.

@oddhack
Copy link
Contributor

oddhack commented Oct 2, 2024

@godlikepanos could you propose a PR adding a NOTE to that section, based on @HansKristian-Work's comment?

@godlikepanos
Copy link
Author

Sorry for the late update. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants