Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous phrase: "the act of waiting" on a binary semaphore #2412

Open
ixchow opened this issue Aug 17, 2024 · 2 comments
Open

Ambiguous phrase: "the act of waiting" on a binary semaphore #2412

ixchow opened this issue Aug 17, 2024 · 2 comments

Comments

@ixchow
Copy link
Contributor

ixchow commented Aug 17, 2024

From Semaphore Waiting:

Unlike timeline semaphores, fences or events, the act of waiting for a binary semaphore also unsignals that semaphore.

This language is ambiguous as to when "the act of waiting" occurs. I believe the intent is that the semaphore is unsignaled after the wait completes; but "the act of waiting" can be read as happening when the wait begins.

I suggest:

Unlike timeline semaphores, fences or events, waiting for a binary semaphore also unsignals that semaphore when the wait completes.

Note that the phrases "when" and "after" are probably -- in the language of the spec -- ill-defined since (as far as I can tell) there isn't necessarily a globally-consistent timeline among all threads of execution implied. On the other hand these words are already used elsewhere in the section.

@ixchow ixchow changed the title Ambiguous note: "the act Ambiguous phrase: "the act of waiting" on a binary semaphore Aug 17, 2024
@dgkoch
Copy link
Contributor

dgkoch commented Aug 21, 2024

@ixchow that sounds reasonable - are you able to provide a pull request with the change?

@ixchow
Copy link
Contributor Author

ixchow commented Aug 21, 2024

Pull request #2418 created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants