-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistant limittype specification #2461
Comments
These do seem inconsistent. The |
Maybe I should have sent this issue to the XML repo, as <member limittype="bits"><type>uint32_t</type> <name>viewportSubPixelBits</name><comment>number bits of subpixel precision for viewport</comment></member>
<member limittype="min,pot"><type>size_t</type> <name>minMemoryMapAlignment</name><comment>min required alignment of pointers returned by MapMemory (bytes)</comment></member>
<member limittype="min,pot"><type>VkDeviceSize</type> <name>minTexelBufferOffsetAlignment</name><comment>min required alignment for texel buffer offsets (bytes) </comment></member>
<member limittype="min,pot"><type>VkDeviceSize</type> <name>minUniformBufferOffsetAlignment</name><comment>min required alignment for uniform buffer sizes and offsets (bytes)</comment></member>
<member limittype="min,pot"><type>VkDeviceSize</type> <name>minStorageBufferOffsetAlignment</name><comment>min required alignment for storage buffer offsets (bytes)</comment></member>
<member limittype="min"><type>int32_t</type> <name>minTexelOffset</name><comment>min texel offset for OpTextureSampleOffset</comment></member>
<member limittype="max"><type>uint32_t</type> <name>maxTexelOffset</name><comment>max texel offset for OpTextureSampleOffset</comment></member> |
Vulkan-Docs holds the canonical version of vk.xml, if that's what you mean by "XML repo". |
This should be fixed in the 1.4.304 spec update. |
Let us assume that if the limittype contains min for limit alpha then:
device->alpha >= limit->alpha
(similar holds for max)As for:
minMemoryMapAlignment
ismin,pot
thendevice->minMemoryMapAlignment >= limit
minStorageBufferOffsetAlignment
is alsomin,pot
sodevice->minStorageBufferOffsetAlignment >= limit
But as
minMemoryMapAlignment
restricts the device (the higher the limit the better), butminStorageBufferOffsetAlignment
restricts the user (the lower the better) maybe (even if it sounds unintuitive) the limits that are restricting the user should have reversed limittypes.Then we would have
minMemoryMapAlignment
:min,pot
, butminStorageBufferOffsetAlignment
would bemax,pot
, but that would align with the device/user restriction reasoning.Originally posted by @qbojj in KhronosGroup/Vulkan-Profiles#703 (comment)
The text was updated successfully, but these errors were encountered: