VUID-VkGraphicsPipelineCreateInfo-pRasterizationState-09039 refers to pMultisampleState, not pRasterizationState

[w-pearson]

Hello, currently VUID-VkGraphicsPipelineCreateInfo-pRasterizationState-09039 reads:

If VkGraphicsPipelineLibraryCreateInfoEXT::flags includes VK_GRAPHICS_PIPELINE_LIBRARY_PRE_RASTERIZATION_SHADERS_BIT_EXT, and related dynamic state is not set, then pMultisampleState must be a valid pointer to a valid VkPipelineMultisampleStateCreateInfo structure

This is a bit weird, as multisample state is not listed in the Pre-Rasterization Shader State section (only in Fragment Shader State and Fragment Output State, and the name refers to pRasterizationState instead of pMultisampleState. Also, the nearby VUID-VkGraphicsPipelineCreateInfo-pRasterizationState-06601 and VUID-VkGraphicsPipelineCreateInfo-pRasterizationState-09040 refer to pRasterizationState.

This is currently unimplemented in Vulkan-ValidationLayers (though the exact reason why is in a private repo I don't have access to).

Is there actually a case where pMultisampleState must be valid in pre-rasterization shader state, or is this a mistake in the spec?

[spencer-lunarg]

This is currently unimplemented in Vulkan-ValidationLayers

So there is no way for validation to know if the pointer is "valid" other than

1. Making sure it is not NULL
2. Making sure the pointer we read has a sType for VkPipelineMultisampleStateCreateInfo

Both are already done by generated VUs like VUID-VkPipelineMultisampleStateCreateInfo-sType-sType so there was nothing to add

---

I also fully agree this VU is confusing and my internal change request was to just remove these as I personally feel they are not required

[w-pearson]

That part mostly makes sense, and applies equally to VUID-VkGraphicsPipelineCreateInfo-pMultisampleState-09027 (which is also unimplemented). My issue is more that this VU says that pMultisampleState is part of pre rasterization shader state even though it's not listed there in the graphics pipeline state subsets sections), and there are no VUs indicating that it must match other libraries (unlike e.g. VUID-VkGraphicsPipelineCreateInfo-flags-06633 through 06635, which say that the fragment shader state and fragment output state need to have identically-defined pMultisampleStates).

For context, I am working on an analysis tool that needs to link pipeline libraries, and this VU mentioning pMultisampleState with pre rasterization shader state confused me.