-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix promoted extension dependencies in vk.xml #2492
Fix promoted extension dependencies in vk.xml #2492
Conversation
Two comments on superficial consistency review (mostly for @spencer-lunarg who signed up as the other reviewer):
Possibly this would affect use of these extensions when 1.2 is supported but the corresponding promoted extension was not. |
@asuessenbach this is getting a Vulkan-Hpp CI failure, but it appears more likely to be a syntax error in the generated code than a problem with this PR - could you take a look? |
Followup: we think that the two partial promotions above should not be reflected in the XML, because they basically make the entire functionality of the extension optional if only 1.2 is supported. @CodingRays could you make those reversions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran through Validation code gen, didn't have any issues, so tooling PoV - LGTM
@oddhack Also found it in |
We discussed and you are correct about the other cases. We think the path forward will be to document the feature restrictions in VU statements since capturing it in the XML is not currently possible. So, signing this off, but we'll have to sort out the CI failure - I think Vulkan-Hpp may have a bug which may or may not have been fixed, so will try re-running it to see if that helps. |
I'm not sure what's up with the hpp-compile CI stage but it's not specific to this PR, so accepting it. Guessing that the underlying image is running an out of date g++ or something like that, as it's affecting other branches as well. |
Fixes #2491