Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify WebGLRenderingContextBase#canvas attribute #3296

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Jul 3, 2021

Web IDL should automatically drop the HTMLCanvasElement part from workers, as in ImageBitmapRenderingContext:

[Exposed=(Window,Worker)]
interface ImageBitmapRenderingContext {
  readonly attribute (HTMLCanvasElement or OffscreenCanvas) canvas;
  undefined transferFromImageBitmap(ImageBitmap? bitmap);
};

Thus there is no need to process it manually. (Doing so makes things hard for IDL processing tools actually, e.g. microsoft/TypeScript-DOM-lib-generator#1050.)

Copy link
Member

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. Spec editor @jdashg should review too.

@kenrussell kenrussell requested a review from kdashg July 5, 2021 00:41
@kdashg kdashg merged commit 495b85b into KhronosGroup:main Jul 6, 2021
@saschanaz saschanaz deleted the simplify-canvas-attr branch July 6, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants