Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16bit Modf is incorrectly depending on SPV_AMD_gpu_shader_half_float #3814

Open
eilswe-arm opened this issue Dec 16, 2024 · 1 comment
Open

16bit Modf is incorrectly depending on SPV_AMD_gpu_shader_half_float #3814

eilswe-arm opened this issue Dec 16, 2024 · 1 comment

Comments

@eilswe-arm
Copy link
Contributor

In #3757 a dependency was added for 16bit Modf on the SPV_AMD_gpu_shader_half_float extension. This is incorrect, and the dependency should rather be on the 16bit float capability.

This causes issues when compiling the resulting spirv on devices without SPV_AMD_gpu_shader_half_float support.
@eilswe-arm eilswe-arm mentioned this issue Dec 16, 2024
Merged
@eilswe-arm
Copy link
Contributor Author

Pull request #3815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eilswe-arm