-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Same client shown more than once #18
Comments
I'm glad you liked the changes!
I can't think of a better way than assigning static addresses. Will look into it though and get back to you.
I used the LuCI CBI SingleForm model which has these buttons by default. You can see that these same buttons appear in the page Network - Firewall - Custom (if I'm not mistaken). Although you might see different text for the |
Ah, okay. That makes sense. Would it be possible to have it recognise new devices based on new mac addresses, rather than new IP addresses, or would that be too much work/out of your control? |
@BradleyDS2 https://drive.google.com/open?id=1LjZ_zyqe_7AafR9Dr_QNuzRHcjRrN9Bz |
Data usage used to be calculated using only MAC addresses, but because of the implementation luci-wrtbmon ended up showing funny values, as seen in issue #7 |
@fakuivan However, I modified the codes of the wrtbwmon rather than the luci-wrtbwmon so that it caculates the traffic data only based on the MAC address. By my modified codes, the same MAC address will not appear more than onces in the file of usage.db, and one MAC address correspond to a unique client. Therefore, the issue #7 could not occur. I modified the wrtbwmon because the wrtbwmon caculate the traffic data by the ip address only. It may recongise the incorrected client if the ip has changed for a client and another client just get the same old ip address of the former. If you are interested in this issue, you can just replace the /usr/sbin/readDB.awk by the file I offered above. I have tested it for some days and no bugs occured up to now. |
Hello! I used your readDB.awk, it works as expected, but exactly until the appearance of a new device on the network. If its traffic is 0 bytes, the statistics in the browser through usage.htm disappears on all devices, only the headings of the columns Download, Upload, Total, etc. remain. When the device has traffic, even 1 byte, statistics appear again. Also, I noticed in the usage.htm file the incorrect layout of the quotes and the absence of the Upload value on this device.
What can you do about it? |
It seems that the problem is solved. Added two "+" in the penultimate section in readDB.awk and began to display statistics for all devices even with their traffic of 0 bytes.
|
Firstly, thank you so much for the recent changes, they're absolutely wonderful!
I've run into a small problem though, I have the same device appearing twice on two occasions in the usage details.
Here's a link to a screenshot, the devices in question are Printer 1 and Printer 2 https://www.dropbox.com/s/0ttu4c1txn6m4p4/Duplicate%20Clients.png?dl=0
And here is my custom user file:
Hovering over Printer 1 and Printer 2 in the usage details shows that both results for Printer 1 have the same mac address and both results for Printer 2 have the same mac address as well.
It looks like they changed IP addresses and now they're being recognised as new devices, even though their mac address is still the same.
Is there any way to fix this other than assigning them static IP addresses?
Also, offtopic, but would it be possible to have the 'Submit' and 'Reset' buttons on the 'User File' page replaced with 'Save & Apply', 'Save' and 'Reset' buttons like in the configuration page and elsewhere in LuCI?
Thanks a lot for all your hard work, it's really appreciated!
The text was updated successfully, but these errors were encountered: