You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once our KclValue type can reliably be used to get appropriate artifact IDs from, replace the current behavior of operation generation to include KclValues for an operation's arguments instead of their source ranges (or in addition too them?).
In a similar vein, return the KclValue for the overall operation, or the artifact ID associated with the operation as well, depending on which is easiest. This will enable the feature tree UI to select the appropriate artifact on selection click, without needing to derive the appropriate artifact from source ranges.
The text was updated successfully, but these errors were encountered:
Did we ever decide whether we want the user to edit the expression or the computed value?
Say the argument is x + 2. When building the operations, we know that the computed value is 42. The intent of this issue was that we would capture 42 and include that in the operation.
However, if we do that and use it to edit in the command bar, and the user changes it to 43, we'd be changing the meaning. It would no longer depend on x.
The expression x + 2 is just an example. It could be an arbitrary expression like a function call. This also applies to objects in the scene also, like getOppositeEdge(seg001).
On the other hand, if we decide they're editing the expression, then you'll want to use the KCL source. That you can get from the source range.
Oh yeah for sure the expression in the case of arguments that can be represented as KCL values in the command palette. So the source range is perfectly fine for those cases.
Clarification: We want the value when it's primitive. But for larger values in the scene, we don't care about most of the KclValue struct. The only thing we care about is its artifact ID.
Blocked by #5186.
Once our
KclValue
type can reliably be used to get appropriate artifact IDs from, replace the current behavior of operation generation to includeKclValue
s for an operation's arguments instead of their source ranges (or in addition too them?).In a similar vein, return the
KclValue
for the overall operation, or the artifact ID associated with the operation as well, depending on which is easiest. This will enable the feature tree UI to select the appropriate artifact on selection click, without needing to derive the appropriate artifact from source ranges.The text was updated successfully, but these errors were encountered: