Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: bcrypt implementation #59

Open
TaborKelly opened this issue May 31, 2019 · 5 comments
Open

Request: bcrypt implementation #59

TaborKelly opened this issue May 31, 2019 · 5 comments

Comments

@TaborKelly
Copy link

A ready to go bcrypt implementation would be a very nice thing to have.

@ianpartridge
Copy link
Contributor

Agreed!

@ianpartridge
Copy link
Contributor

Note that CommonCrypto doesn't seem to have a bcrypt implementation, which may make this impossible as we don't provide crypto in this library - just APIs on top.

@billabt
Copy link
Collaborator

billabt commented Jun 5, 2019

That’s correct. That’s why I didn’t do an implementation before. Somebody was working on an implementation that could be integrated awhile back but never submitted a PR for it. I’ll take a look and see what it would take. There’s bound to be an open source implementation around that's of proper quality that it could be modified and integrated into the library. I found one earlier but it was way too bloated and other commitments sidetracked me and I never got back to it. Any suggestions of a good, lean implementation that might used? Even one in C would be fine if self contained, I could port it over to Swift rather quickly.

@TaborKelly
Copy link
Author

I concur. I erroneously though that CommonCrypto exposed EksBlowfishSetup(), but it doesn't as far as I can tell. I threw this together over the weekend and you are welcome to use it, but I'm not sure if it meets your IP requirements or not:
https://github.com/TaborKelly/Bcrypt

@ianpartridge
Copy link
Contributor

Thank you for linking but I'm afraid we couldn't take a pure Swift implementation. This project does not embed crypto itself, so we couldn't integrate C code either. What we could do is have API which delegated to OpenSSL on Linux, and was non-functional on Darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants