Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KongConsumerGroup status changes should trigger depending KongConsumer reconciliation #645

Open
2 tasks
czeslavo opened this issue Sep 25, 2024 · 2 comments
Open
2 tasks

Comments

@czeslavo
Copy link
Contributor

Problem Statement

When the status of KongConsumerGroup that a given KongConsumer depends on changes (e.g. its Programmed condition changes to True), it should trigger KongConsumer's reconciliation despite the fact the KongConsumer's generation and Programmed condition's observedGeneration are equal.

Proposed Solution

Keep the last observed generations of the KongConsumerGroups the KongConsumer references in the KongConsumer's status. Compare those with the current generation of every KongConsumerGroup referenced by a KongConsumer in the shouldUpdate function and decide based on that (observed generation != current generation => should update).

Additional Information

The issue was worked around in #638 by returning an error from the KongConsumer reconciler when any of the referenced KongConsumerGroups is not Programmed yet. It should be changed once we fix this issue.

Acceptance Criteria

  • KongConsumer reconciliation is triggered on every KongConsumerGroup change (update is not skipped)
  • KongConsumer can become Programmed even if the KongConsumerGroup is not programmed yet
@czeslavo czeslavo added this to the KGO v1.5.x milestone Sep 25, 2024
@pmalek
Copy link
Member

pmalek commented Oct 8, 2024

The same issue affects KonnectGatewayControlPlane and their groups: when e.g. one of the CP group members gets deleted or get its Programmed status condition changed from False to True we should reconcile the group as well and reflect its state in its status.

@pmalek
Copy link
Member

pmalek commented Oct 25, 2024

This also affects removing targets of KongPluginBinding, re #805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants