You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the status of KongConsumerGroup that a given KongConsumer depends on changes (e.g. its Programmed condition changes to True), it should trigger KongConsumer's reconciliation despite the fact the KongConsumer's generation and Programmed condition's observedGeneration are equal.
Proposed Solution
Keep the last observed generations of the KongConsumerGroups the KongConsumer references in the KongConsumer's status. Compare those with the current generation of every KongConsumerGroup referenced by a KongConsumer in the shouldUpdate function and decide based on that (observed generation != current generation => should update).
Additional Information
The issue was worked around in #638 by returning an error from the KongConsumer reconciler when any of the referenced KongConsumerGroups is not Programmed yet. It should be changed once we fix this issue.
Acceptance Criteria
KongConsumer reconciliation is triggered on every KongConsumerGroup change (update is not skipped)
KongConsumer can become Programmed even if the KongConsumerGroup is not programmed yet
The text was updated successfully, but these errors were encountered:
The same issue affects KonnectGatewayControlPlane and their groups: when e.g. one of the CP group members gets deleted or get its Programmed status condition changed from False to True we should reconcile the group as well and reflect its state in its status.
Problem Statement
When the status of
KongConsumerGroup
that a givenKongConsumer
depends on changes (e.g. itsProgrammed
condition changes toTrue
), it should triggerKongConsumer
's reconciliation despite the fact theKongConsumer
'sgeneration
andProgrammed
condition'sobservedGeneration
are equal.Proposed Solution
Keep the last observed generations of the
KongConsumerGroup
s theKongConsumer
references in theKongConsumer
'sstatus
. Compare those with the current generation of everyKongConsumerGroup
referenced by aKongConsumer
in the shouldUpdate function and decide based on that (observed generation != current generation => should update).Additional Information
The issue was worked around in #638 by returning an error from the
KongConsumer
reconciler when any of the referencedKongConsumerGroup
s is notProgrammed
yet. It should be changed once we fix this issue.Acceptance Criteria
KongConsumer
reconciliation is triggered on everyKongConsumerGroup
change (update is not skipped)KongConsumer
can becomeProgrammed
even if theKongConsumerGroup
is not programmed yetThe text was updated successfully, but these errors were encountered: