Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limits of fields in KongConsumer and KongConsumerGroup #773

Open
randmonkey opened this issue Oct 22, 2024 · 1 comment
Open

Limits of fields in KongConsumer and KongConsumerGroup #773

randmonkey opened this issue Oct 22, 2024 · 1 comment
Labels
Milestone

Comments

@randmonkey
Copy link
Contributor

Current Behavior

Limits of Consumers in Konnect:

  • username's length < 128 and match regex ^[\p{L}\p{N}.\-_~+@/\[\]]+(?: [\p{L}\p{N}.\-_~+@/\[\]]+)*$
  • custom_id match regex ^[0-9a-zA-Z.\-_~\(\)#%@|+\[\]]+(?: [0-9a-zA-Z.\-_~\\(\)#%@|+\\[\\]]+)*$
    Limits of consumer groups in Konnect:
  • name's length < 128 and match regex ^[\p{N}\p{L}.\-_~]*$

Currently they are not validated on CRD layer or controller layer, and invalid KongConsumer or KongConsumerGroup will be sent to Konnect and get 400 responses. Controller keeps retry in such cases.

Expected Behavior

Either:

  • Validate and reject invalid instances of KongConsumers and KongConsumerGroups
  • Or detect the validation errors and stop reconciliations of invalid resources

Steps To Reproduce

Operator Version

kubectl version

@randmonkey randmonkey added bug Something isn't working area/konnect labels Oct 22, 2024
@randmonkey randmonkey added this to the KGO v1.4.x milestone Oct 22, 2024
@czeslavo czeslavo modified the milestones: KGO v1.4.x, KGO v1.5.x Oct 23, 2024
@pmalek
Copy link
Member

pmalek commented Oct 29, 2024

... invalid KongConsumer or KongConsumerGroup will be sent to Konnect and get 400 responses. Controller keeps retry in such cases.

With recent introduction of

return ctrl.Result{}, IgnoreUnrecoverableAPIErr(err, loggerForEntity(ctx, e, UpdateOp))
and
return e, IgnoreUnrecoverableAPIErr(err, loggerForEntity(ctx, e, CreateOp))
those should be ignored (i.e. the error shouldn't be reported from the reconcile loop and thus this should not be retried).

@randmonkey randmonkey modified the milestones: KGO v1.4.x, KGO v1.5.x Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants