Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink locking in clusters.Cleaner #563

Open
pmalek opened this issue Feb 13, 2023 · 0 comments
Open

Rethink locking in clusters.Cleaner #563

pmalek opened this issue Feb 13, 2023 · 0 comments

Comments

@pmalek
Copy link
Member

pmalek commented Feb 13, 2023 •
edited

I'm not sure in practice if this will end up mattering, but it seems a bit odd to make the actual cleanup a "ready only" lock, considering all the mutations it's making.

Actually, it occurs to me now that what we should probably do is lock the object and block all future changes once we've run cleanup. E.g. any Add to the cleaner fails after Cleanup is called.

Originally posted by @shaneutt in #552 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmalek