Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running integration and E2E tests in tests workflow for external contributors #596

Open
1 of 2 tasks
czeslavo opened this issue Mar 22, 2023 · 5 comments
Open
1 of 2 tasks

Comments

@czeslavo
Copy link
Contributor

czeslavo commented Mar 22, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

KTF's integration and E2E tests require secrets to run (for the Kong license, and for access to GKE). That makes them fail for PRs from external contributors. We'd like to run them against every PR, therefore we need to come up with a solution to that.

Proposed Solution

Trigger tests.yaml workflow on pull_request_target and ensure that in case a pull request author is an external contributor, the PR has to have a predefined label assigned (e.g. verified-for-running-ci) that would be assigned by a reviewer after ensuring that no potential secrets leak can happen due to the changes from PR.

Implement the workflow described by Michael Heap in his blogpost.

Additional information

No response

Acceptance Criteria

  • Integration and E2E tests can be run against PRs submitted by external contributors
@shaneutt
Copy link
Contributor

What's left after #597 to consider this resolved?

@pmalek
Copy link
Member

pmalek commented Mar 22, 2023

Actually run the integration (and if possible e2e) tests on PRs from forks. Now they are just skipped to not cause trouble.

Since tests here are not grouped or tagged in any way to indicate they require a license we'd need to add that perhaps and only run those that don't require it (if we want to run something but not expose secrets)

@czeslavo czeslavo changed the title Allow running integration and E2E tests in tests workflow for external contributors' Allow running integration and E2E tests in tests workflow for external contributors Mar 22, 2023
@shaneutt
Copy link
Contributor

Looks like @astoycos's PR #591 is working, so I think we're set!

@randmonkey
Copy link
Contributor

Seems integration tests could run after merging #632. For e2e tests which is running on GKE, I think we may need a new issue to track how to enable GKE tests on forks.

@shaneutt
Copy link
Contributor

Seems integration tests could run after merging #632. For e2e tests which is running on GKE, I think we may need a new issue to track how to enable GKE tests on forks.

Sounds good. As I remember it the GKE tests wont run unless the GKE_CREDS are present? If that's still the case that's probably fine as its minimally disruptive if not we could consider making it that way. These kinds of variances do however scream for a need for documentation, particularly better contributor guidance. We should get ahold of whatever miscreant started this repo and ask them "where is the documentation". 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants