pb: Add copy method to generated messages
#539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr3zee
approved these changes
Nov 28, 2025
Member
Mr3zee
left a comment
Mr3zee
left a comment
There was a problem hiding this comment.
Lgtm, and please see the changes before merging
...mmonMain/generated-code/kotlin-multiplatform/com/google/protobuf/kotlin/_rpc_internal/Api.kt
Show resolved
Hide resolved
...uf-core/src/commonMain/generated-code/kotlin-multiplatform/com/google/protobuf/kotlin/Any.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@Mr3zee I replaced the |
Mr3zee
approved these changes
Nov 28, 2025
...-gen/protobuf/src/main/kotlin/kotlinx/rpc/protoc/gen/ModelToProtobufKotlinCommonGenerator.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Protobuf
Problem Description
Messages had no
copymethod to easily creating an altered message instance.Solution
This PR adds the
copy {}extension function, which will produce a deep copy of the receiver message.Users can override copied fields as with the
invoke/constructor function.Limitation
The copy function should also preserve all unknown message fields.
However, as unknown fields are not yet stored (just discarded), this isn't implemented yet.