Core: Link to async hook example from async module callback error

Add link to the new example added in 086a0db from the new error
message introduced in qunitjs#1761 (bad99f9),
and rephrase the error message slightly to sound more like some of
our other error messages.

* TypeError instead of Error.
* mention "QUnit.module() callback" explicitly.

Author: Krinkle

src/module.js

@@ -89,8 +89,7 @@ function processModule (name, options, executeNow, modifiers = {}) {
   }
 
   if (isAsyncFunction(executeNow)) {
-    throw new Error('Async module callbacks are not supported. ' +
-      'Instead, use hooks for async behavior.');
+    throw new TypeError('QUnit.module() callback must not be async. For async module setup, use hooks. https://qunitjs.com/api/QUnit/module/#hooks');
   }
 
   const module = createModule(name, options, modifiers);
@@ -120,10 +119,7 @@ function processModule (name, options, executeNow, modifiers = {}) {
     try {
       const cbReturnValue = executeNow.call(module.testEnvironment, moduleFns);
       if (cbReturnValue && typeof cbReturnValue.then === 'function') {
-        throw new Error(
-          'Returning a promise from a module callback is not supported. ' +
-            'Instead, use hooks for async behavior.'
-        );
+        throw new TypeError('QUnit.module() callback must not be async. For async module setup, use hooks. https://qunitjs.com/api/QUnit/module/#hooks');
       }
     } finally {
       // If the module closure threw an uncaught error during the load phase,

test/cli/fixtures/async-module-error-promise.tap.txt

@@ -5,10 +5,10 @@ not ok 1 global failure
   ---
   message: |+
     Error: Failed to load file async-module-error-promise.js
-    Error: Returning a promise from a module callback is not supported. Instead, use hooks for async behavior.
+    TypeError: QUnit.module() callback must not be async. For async module setup, use hooks. https://qunitjs.com/api/QUnit/module/#hooks
   severity: failed
   stack: |
-    Error: Returning a promise from a module callback is not supported. Instead, use hooks for async behavior.
+    TypeError: QUnit.module() callback must not be async. For async module setup, use hooks. https://qunitjs.com/api/QUnit/module/#hooks
         at qunit.js
         at /qunit/test/cli/fixtures/async-module-error-promise.js:1:7
         at internal

test/cli/fixtures/async-module-error-thenable.tap.txt

@@ -5,10 +5,10 @@ not ok 1 global failure
   ---
   message: |+
     Error: Failed to load file async-module-error-thenable.js
-    Error: Returning a promise from a module callback is not supported. Instead, use hooks for async behavior.
+    TypeError: QUnit.module() callback must not be async. For async module setup, use hooks. https://qunitjs.com/api/QUnit/module/#hooks
   severity: failed
   stack: |
-    Error: Returning a promise from a module callback is not supported. Instead, use hooks for async behavior.
+    TypeError: QUnit.module() callback must not be async. For async module setup, use hooks. https://qunitjs.com/api/QUnit/module/#hooks
         at qunit.js
         at /qunit/test/cli/fixtures/async-module-error-thenable.js:1:7
         at internal

test/cli/fixtures/async-module-error.tap.txt

@@ -5,10 +5,10 @@ not ok 1 global failure
   ---
   message: |+
     Error: Failed to load file async-module-error.js
-    Error: Async module callbacks are not supported. Instead, use hooks for async behavior.
+    TypeError: QUnit.module() callback must not be async. For async module setup, use hooks. https://qunitjs.com/api/QUnit/module/#hooks
   severity: failed
   stack: |
-    Error: Async module callbacks are not supported. Instead, use hooks for async behavior.
+    TypeError: QUnit.module() callback must not be async. For async module setup, use hooks. https://qunitjs.com/api/QUnit/module/#hooks
         at qunit.js
         at /qunit/test/cli/fixtures/async-module-error.js:2:7
         at internal

test/main/modules.js

@@ -466,8 +466,8 @@ QUnit.module('QUnit.module', function () {
     }
 
     QUnit.test('thenable callback function errored', function (assert) {
-      assert.true(caught instanceof Error);
-      assert.strictEqual(caught.message, 'Returning a promise from a module callback is not supported. Instead, use hooks for async behavior.');
+      assert.true(caught instanceof TypeError);
+      assert.strictEqual(caught.message, 'QUnit.module() callback must not be async. For async module setup, use hooks. https://qunitjs.com/api/QUnit/module/#hooks');
     });
   });
 });