cashews.backends.interface._BackendInterface.lock annotation breaking change from 4.1.0 -> 5.0.0

[rkrell]

I got some difficulties after migrating cashews from 4.1.0 to 5.0.0.

In the following code:

    async def dispatch(subject: bytes, body: bytes) -> bytes:
            ...
            key = REDIS_REDLOCK_NAMESPACE + ':' + \
                subj_str + '(' + body.hex() + ')'
            # Repeated calls with equal key will wait here
            # at most for lease time:
            async with cache.lock(key + '-lock', expire=LEASE_LOCK_FUNC_CACHE):
                result = await cache.get(key)
                if result is not None:
                   ... # Cached result
                await cache.set(key, result.hex(), expire=EXPIRE_FUNC_CACHE)
                return result

I get the following error in cashews 5.0.0, but not in 4.1.0:

Traceback (most recent call last):
  File "/home/production/automation/packing/application.py", line 72, in consume_message
  File "/home/production/automation/packing/dispatch.py", line 103, in dispatch
  File "/home/production/lib/python3.7/contextlib.py", line 170, in __aenter__
    return await self.gen.__anext__()
  File "/home/production/automation/lib/python3.7/site-packages/cashews/backends/interface.py", line 133, in lock
    key: str,
  File "/home/production/automation/lib/python3.7/site-packages/cashews/wrapper.py", line 241, in set_lock
  File "/home/production/automation/packing/application.py", line 40, in cache_logging_middleware
  File "/home/production/automation/lib/python3.7/site-packages/cashews/validation.py", line 80, in _invalidate_middleware
  File "/home/production/automation/lib/python3.7/site-packages/cashews/wrapper.py", line 37, in _auto_init
    pass
  File "/home/production/automation/lib/python3.7/site-packages/cashews/disable_control.py", line 16, in _is_disable_middleware
    def __init__(self, *args, **kwargs):
TypeError: set_lock() got multiple values for argument 'key'

Below there are the relevant changes from the commit that caused this:

Index: packing/application.py
===================================================================
diff --git a/packing/application.py b/packing/application.py
--- a/packing/application.py	(revision a37e692d9b19e746c2652ca239be414e5ed424fe)
+++ b/packing/application.py	(revision 2be8670d7afb0f2039dfb24f615c5ba758ed33db)
@@ -4,7 +4,7 @@
 import struct
 from logging.config import dictConfig
 
-import aioredis
+import redis.asyncio as redis
 import httpx
 from aiorun import run
 from cashews import cache
@@ -55,7 +55,7 @@
                 password=redis_password,
                 retry_on_timeout=True,
                 prefix=REDIS_REDLOCK_NAMESPACE)
-    status.g_redis = aioredis.from_url(
+    status.g_redis = redis.from_url(
         f"redis://{cfg.redis.endpoint}:{cfg.redis.port}/0",
         password=redis_password,
         retry_on_timeout=True
@@ -157,6 +157,7 @@
                 "There is already a running process in background,"
                 " launching skipped")
     finally:
+        await status.g_redis.close()
         if gotten:
             lock.release()
 
Index: packing/status.py
===================================================================
diff --git a/packing/status.py b/packing/status.py
--- a/packing/status.py	(revision a37e692d9b19e746c2652ca239be414e5ed424fe)
+++ b/packing/status.py	(revision 2be8670d7afb0f2039dfb24f615c5ba758ed33db)
@@ -2,7 +2,7 @@
 import asyncio
 import logging
 from typing import List, Optional, Tuple
-from aioredis import Redis
+import redis.asyncio as redis
 
 import httpx
 
@@ -36,7 +36,7 @@
 
 g_http: httpx.AsyncClient
 
-g_redis: Redis
+g_redis: redis.Redis
 
 
 async def unlock():
Index: requirements.txt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/requirements.txt b/requirements.txt
--- a/requirements.txt	(revision a37e692d9b19e746c2652ca239be414e5ed424fe)
+++ b/requirements.txt	(revision 2be8670d7afb0f2039dfb24f615c5ba758ed33db)
@@ -6,8 +6,8 @@
 pydantic==1.6.1
 aiorun==2020.6.1
 
-aioredis==2.0.1
-cashews[redis]==4.1.0
+redis==4.3.4
+cashews[redis]==5.0.0
 
 #Deps: aiofiles-0.6.0 aiosqlite-0.16.0 cryptography-3.2.1 lxml-4.6.1 python-dateutil-2.8.1 pytz-2020
 asyncua==0.9.0

Is there anyone able to help what's wrong here with my code?
Unfortunately I haven't found any Changelog pointing out the relevant breaking changes.

Thanks in advance.

[rkrell]

Maybe the following middleware I have is also of interest here:

async def cache_logging_middleware(
        call, *args, backend=None, cmd=None, **kwargs):
    key = args[0] if args else kwargs.get("key", kwargs.get("pattern", ""))
    logging.info("Redis cache request: %s %s", cmd, key,
                 extra={"command": cmd, "cache_key": key})
    return await call(*args, **kwargs)

...

# Initialization here:
from cashews import cache

    cache.setup(f"redis://{cfg.redis.endpoint}:{cfg.redis.port}/0",
                middlewares=(
                          cache_logging_middleware,
                ),
                password=redis_password,
                retry_on_timeout=True,
                prefix=REDIS_REDLOCK_NAMESPACE)

[rkrell]

Isn't it the change middleware interface, thus, correct in this way?

async def cache_logging_middleware(
        call, cmd: Command, backend: Backend, *args, **kwargs):
    key = args[0] if args else kwargs.get("key", kwargs.get("pattern", ""))
    logging.info("Redis cache request: %s", cmd.value,
                 extra={"command": cmd, "cache_key": key})
    return await call(*args, **kwargs)

[Krukov]

Yes, the signature of middleware have changed in 5.0.

Yep your new version is correct