-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RateLimitPolicy v1beta4
#951
Comments
We can keep |
|
do we want the counter to be a CEL expression? What is the point of being CEL expression? Maybe it is enough with one of the following? counters:
- attribute: source.remote_address or counters:
- source.remote_address |
how are you example not CEL expresssions? what's |
I was thinking on a simple selector for counters. Yes. But maybe we can leverage CEL to do some transformations counters:
- dayOfTheWeek(request.time) Could be handy |
Right, plus there is no benefit in treating the two differently, more so that they look exactly the same! counters:
- expression: request I could argue for JSON serialization (on a single line) as this is how Authorino currently sends the data back too. But I would think that CEL literals would be better. Good news is that it pretty much becomes opaque to the user at this stage. |
Ideally our APIs feel similar... This proposal here is heavily influenced by the introduction of CEL in
AuthConfig
, as these types will "leak" to ourAuthPolicy
eventually, here's how this could look like forRateLimitPolicy
:The text was updated successfully, but these errors were encountered: