Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Proxy" Type for Proxy Settings #98

Open
2 tasks done
nimaxin opened this issue Oct 19, 2024 · 0 comments
Open
2 tasks done

Add "Proxy" Type for Proxy Settings #98

nimaxin opened this issue Oct 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@nimaxin
Copy link

nimaxin commented Oct 19, 2024

Checklist

  • I believe the idea is awesome and would benefit the framework
  • I have searched in the issue tracker for similar requests, including closed ones

Description

Currently, the Client.proxy parameter only takes a dict, which can be confusing. I suggest adding a Proxy type and ProxyScheme enum to improve clarity and make the available parameters and schemes explicit.

Example usage:

Client(
    proxy=Proxy(
        scheme=ProxyScheme.HTTP,
        hostname="127.0.0.1",
        port=12345,
        username="username",
        password="password",
    ),
)

I’m happy to submit a PR to implement this feature. Let me know if you're open to it.

@nimaxin nimaxin added the enhancement New feature or request label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant