Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for websockets to reconnect #165

Open
clrxbl opened this issue Jul 21, 2023 · 1 comment · May be fixed by #169
Open

Allow for websockets to reconnect #165

clrxbl opened this issue Jul 21, 2023 · 1 comment · May be fixed by #169
Assignees
@kezz
Labels
type: enhancement

Comments

@clrxbl
Copy link

clrxbl commented Jul 21, 2023

CleanShot 2023-07-21 at 17 29 58@2x

Currently, if the browser loses it's connection to the websocket, it never attempts to reconnect and you are required to reload the page. It'd be nice if it could just reconnect.
@kezz kezz self-assigned this Jul 24, 2023
@kezz
Copy link
Member

kezz commented Jul 24, 2023

Could be as simple as just remaking the socket, I'll give it a go internally and then upstream it if it's a "good" solution

@kezz kezz linked a pull request Jul 24, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kezz kezz

Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: Automatically reconnect the websocket connection on close KyoriPowered/adventure-webui
3 participants
@kezz @kashike @clrxbl