Adventure weighs hue too heavily when comparing colors

[jtJava]

adventure/api/src/main/java/net/kyori/adventure/text/format/TextColorImpl.java

Line 71 in 5919a35

static float distance(final @NotNull HSVLike self, final @NotNull HSVLike other) {

The distance method when comparing two colors causes a color like #f6fff5 (white with very slight green tint) to be downsampled to green instead of white.

[zml2008]

tbh not a priority for us to look into, since downsampling is rarely used outside of super legacy situations, but PRs are welcome (with visual comparisons)

[jtJava]

I'm writing code for the latest version of Paper, I'd like to make use of modern colors while still allowing legacy clients to be able to play my server without seeing god awful color translation.

What do you need to see in the pull request? Is this not as simple as just removing the multiplication by three?

[zml2008]

legacy clients are at the bottom of our priority list these days, it's 2024