-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScopedComponent doesn't always respect initial component type #1154
Labels
Comments
see ScopedComponent |
Added a quick test to ensure we don't miss these in the future, the list it gives is:
I'll filter deprecated methods and give us an exclusion annotation to use, but this gives us an easy list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While messing around with some components, an issue arose when using
Component#font(Key)
on its own outside of builders. It doesn't respect the initial provided component type in it's returned output.EDIT: after a bit more messing around these are all the effected methods
ScopedComponent#font(Key)
,ScopedComponent#style(Consumer<Builder>, Strategy)
,ScopedComponent#appendNewLine()
,ScopedComponent#appendSpace()
,ScopedComponent#applyFallbackStyle(StyleBuilderApplicable...)
,ScopedComponent#applyFallbackStyle(Style)
,ScopedComponent#decorate(TextDecoration....)
,ScopedComponent#decorateIfAbsent(TextDecoration, TextDecoration$State)
,ScopedComponent#decorations(Set<TextDecoration>, boolean)
,ScopedComponent#decorations(Map<TextDecoration, TextDecoration$State>)
,ScopedComponent#replaceText(Consumer<Builder>)
, andScopedComponent#replaceText(TextReplacementConfig)
I've left out the
#compact
method since just like#asComponent
it seems more intentional design wise for it to beComponent
The text was updated successfully, but these errors were encountered: