[BUG]: Firefox sometimes doesn't tile after opening

[Insprill]

Describe the bug
Firefox sometimes (more often than not) doesn't tile correctly after being opened. Increasing the delay here to 50ms fixes the issue in my testing. 25ms works most of the time, but it would still fail occasionally.

komorebi/komorebi/src/window.rs

Lines 493 to 495 in 6b42587

	if exe_name.contains("firefox") {
	std::thread::sleep(Duration::from_millis(10));
	}

As a side note, has an issue been created on Mozilla's bug tracker to potentially get this issue fixed in Firefox instead of having to work around it here?

To Reproduce
Steps to reproduce the behavior:

1. Open a new Firefox window.
2. Observe it is not tiled correctly. If it is tiled correctly, close it and try again, moving windows around so it isn't opening in the same location.

Operating System

OS Name:                   Microsoft Windows 11 Pro for Workstations
OS Version:                10.0.22631 N/A Build 22631

komorebic check Output

No KOMOREBI_CONFIG_HOME detected, defaulting to C:\Users\Insprill

Looking for configuration files in C:\Users\Insprill

Found komorebi.json; this file can be passed to the start command with the --config flag

No ~/.config/whkdrc found; you may not be able to control komorebi with your keyboard

[LGUG2Z]

Nothing has been opened on the Firefox tracker AFAIK. There are a few other programs I'm sure that this delay could be useful for, I think it makes sense to look at making the list of executables to match against configurable as well as the timing, which I suspect is probably dependent on the specs of the machine where komorebi is running.

[mmikeww]

my suspicion is that my chrome extension bugs would also be fixed if they could also be delayed before being tiled

perhaps this configurability setting should be added to the applications.yaml and keep a list of all known programs in there

[Insprill]

Do we know what the applications, Firefox at least in this case, are doing that causes them to not be tiled correctly? Investigating that would be better since relying on fixed delays is extremely fragile. I don't know much about the inner workings of Komorebi, but could it detect when an application tries to resize/reposition itself shortly after opening (or always?) and force it back to the correct size/place?

[mmikeww]

Of course that would be preferable. But what Firefox might be doing, vs what the chrome extensions might be doing, vs whatever the next problem is, could all be different. One thing you can count on in Windows, is that there are never ending edge cases. So I think it's worthwhile to have a catch all method sooner rather than later to simply have a window match where we can trigger an intentional delay. Saves user and dev headaches in the meantime until deeper realer fixes can be found

…

On Sat, Apr 20, 2024, 2:14 PM Pierce Thompson ***@***.***> wrote: Do we know what the applications, Firefox at least in this case, are doing that causes them to not be tiled correctly? Investigating that would be better since relying on fixed delays is extremely fragile. I don't know much about the inner workings of Komorebi, but could it detect when an application tries to resize/reposition itself shortly after opening (or always?) and force it back to the correct size/place? — Reply to this email directly, view it on GitHub <#771 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOQBDCTMPLROAKMYUTRKLLY6KWBBAVCNFSM6AAAAABGNMHQECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXG42DOMBSG4> . You are receiving this because you commented.Message ID: ***@***.***>