-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Some applications resize off-screen #841
Comments
May I ask which layout you tested on? This is how it looks on BSP I am on the 69680b4 commit |
I don't have any set, so it's the default, which I believe is BSP. I updated to 69680b4 and the issue is still present. I did a little more testing, and it appears like sometimes it'll tile correctly. I recorded a video showcasing the inconsistency. You can see it tiles correctly in the left and bottom-middle slots, but it goes "out-of-bounds" in the top-right and bottom-right. komorebi-audacity-bug.mp4 |
Could it be something with your border and spacing settings? I tried to move with console and mouse and could not break it. This is what I have
Would it also break if you open file explorer windows instead of the powershell? I really hope we can narrow it down a bit :) |
It'll break while tiled with any application. I tested with Explorer, Firefox, and Alacritty. My Komorebi config can be found on GitHub. I'm not currently running Zebar, and I'm not testing on the first workspace with the layout set (tested on 3, 4, and 5) I do have three monitors, with one of them vertical, so maybe it's related to that? |
That is a good question, I did try again with your settings, but it did not break. I have 2 identical monitors with the same resolution. I was just hoping we could narrow down the use case for the bug, but we might need to wait for someone else to test or you might need to dig a bit deeper. I did have some bugs myself that LGUG2Z could not reproduce, but he gave me good ways to test this on my own. Perhaps he has a better way to test this, maybe using the Sorry I could not be more help :( |
|
I tried to set the 1st monitor to 100% scaling in portrait and the 2nd to 125% scaling in landscape mode. I moved audacity around with commands and mouse, but I could not break it :( I gave it a good try, I swear. I can see how this is quite "the pebble in your shoe". If you say that scaling makes it worse, then that helps to reproduce it at least. If it was me I would try to look at some logs, but I am not sure if you are up for that :) |
It's not just that different scaling makes it worse; if all monitors are at 100% scale, the issue goes away completely. Perhaps it's also related to differing resolutions between monitors? I ran |
I've just quickly tried Audacity with both 100% and 125% scaling on my monitor (5120x2160) and haven't been able to reproduce anything like what your videos are showing. It would be useful to check the dimensions given for that container in the state for a window that is rendering as expected and one that is rendering past its bounds 🤔 |
Just tried this with two monitors connected, 5120x2160@125% and 1280x720@100%, still could not reproduce. The Rect output in the state for each Window is actually reading directly from the Windows API, can you grab the Rects from
Then compare this with the output for each of the windows on that workspace as reported from the Win32 API:
Add the relevant monitor and workspace index numbers where indicated in the |
I'm curious as both of you tested with the primary monitor scaled higher, can you repro if your primary monitor is 100% and the secondary is 125%? First CommandBroken[
{
"left": 4,
"top": 4,
"right": 1714,
"bottom": 1400
},
{
"left": 1722,
"top": 4,
"right": 1714,
"bottom": 672
},
{
"left": 1722,
"top": 680,
"right": 855,
"bottom": 724
},
{
"left": 2581,
"top": 680,
"right": 855,
"bottom": 724
}
] Good[
{
"left": 4,
"top": 4,
"right": 1714,
"bottom": 1400
},
{
"left": 1722,
"top": 4,
"right": 1714,
"bottom": 672
},
{
"left": 1722,
"top": 680,
"right": 855,
"bottom": 724
},
{
"left": 2581,
"top": 680,
"right": 855,
"bottom": 724
}
] Second CommandBroken{
"left": 4,
"top": 4,
"right": 1714,
"bottom": 1400
}
{
"left": 1722,
"top": 4,
"right": 1714,
"bottom": 672
}
{
"left": 1722,
"top": 680,
"right": 855,
"bottom": 724
}
{
"left": 2581,
"top": 255,
"right": 854,
"bottom": 1149
} Good{
"left": 4,
"top": 4,
"right": 1714,
"bottom": 1400
}
{
"left": 1722,
"top": 4,
"right": 1714,
"bottom": 672
}
{
"left": 1722,
"top": 680,
"right": 855,
"bottom": 724
}
{
"left": 2581,
"top": 680,
"right": 855,
"bottom": 724
} |
Looking at the output of the first command you can see that for both broken/good the However as the second command shows, something happened after komorebi sent the Unfortunately whatever happens after komorebi sends the API calls to Windows is a black box and there isn't really a way for us to know why the position given to |
Also just tried this but still wasn't able to repro :/ |
The weird thing is that, if I'm correct, Do either of you have an AMD GPU? I don't have an Nvidia card to test on currently, but I'm also wondering if it could be related to that 🤔 |
Anything is possible 😅 For what it's worth all my tests were with an Nvidia GPU. |
I also have an Nvidia GPU and you are right, this seems to be a deeply rooted issue somewhere that is not easy to reproduce. It would be worth for someone to attempt this on an AMD machine with 2 monitors. |
@Insprill A lot has changed since, do you still have this issue or know more about it? |
I actually haven't updated komorebi since my last report. I'll update it tomorrow and report back. Hopefully it is since I have an ever-growing list of applications that need a tiny terminal open to use 😅 |
I am not sure what you used before to make your windows transparent, but now komorebi has that added as well. Thought you might want to know so perhaps you can get rid of one app with a tiny terminal 😄 "transparency": true,
"transparency_alpha": 220, |
I just updated komorebi to c022438 and the issue is unfortunately still present :/ I've been using Alacritty's opacity option to make it transparent, but having transparency in komorebi would be amazing, one step closer to matching my Hyprland config :P |
Well, thank you for checking it anyway. When the komorebi bar is added eventually, I do have a few ideas inspired by Hyprland that I am planning on working on 😉 |
I have something, I am on c022438 and look at this "audacity". Recording.2024-06-13.192901.mp4I am using shortcuts to move Audacity around, but as soon as I move any other window on the screen, Audacity disappears and I can only bring it back by "moving" the borders (I can minimize and restore the window as well to bring it back). Edit: This was on my "right" monitor. When I do the same on the "left" monitor, I can see that Audacity is "moved" to the "right" monitor. |
Changing any setting that increases the distance of windows from the edges of the display fixes this problem (e.g. |
These are my settings that are related to spacing and sizes. The video still valid for me and Audacity jumps around the screen. "default_workspace_padding": 10,
"default_container_padding": 10,
"border_padding": 5,
"border_width": 3,
"border_offset": -1,
"stackbar": {
"height": 40,
"label": "Title",
"mode": "OnStack",
"tabs": {
"width": 300,
"focused_text": "#bfaa69",
"unfocused_text": "#dfe2f3",
"background": "#121826"
}
},
"global_work_area_offset":
{
"bottom": 45,
"left": 0,
"right": 0,
"top": 45
}, if you were referring to your original issue, then that is a step forward, I think. perhaps Audacity should just be floated 😄 |
Yes, I was referring to my issue; I'm unsure if yours relates to this. Audacity isn't the only program that this happens to me with; there are several others (GIMP, Python installer, MOTU drivers, probably a couple of others I'm forgetting), most of which I would like to be tiled - that is the reason I'm using komorebi after all :P Increasing |
Then I think we should keep focus on your issue for now, a solution to that might just fix mine as well. |
I had this exact same issue while writing my own window manager, did some tests, and found out these prerequisites to trigger it (on Windows 10 Build 19045 at least):
For example, we have 2 monitors arranged horizontally, each with a resolution of 1920x1080, but the left one has 96 DPI, and the right 192. For a window of width 100, displayed on the left monitor, it has 7 pixels of invisible border on the left and right sides. Trying to place it further right from the x coordinate 1806 would trigger this issue. I couldn't find a proper solution either. It seems there are only two ways to go as a user:
Hopefully the situation would improve over time, as the applications & GUI tool kits are adding high DPI support. |
Experiencing this with Notepad++ main - 4k monitor 150% scaling When notepad++ touches the edge between the displays it scales improperly. Setting the secondary to 150% scaling fixes it, but it is unusable sadly. To reproduce you have to use 0 workspace padding most likely. |
Describe the bug
Some applications (Python installer, Motu drivers, Audacity) will resize their windows higher than it should be, making it impossible to use them.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The windows should render in their tile.
Screenshots and Videos
It's quite easy to see with a transparent window tiled above the application.
When the window is on it's own, it's just offscreen
Operating System
komorebic check
OutputAdditional context
Currently running 77fc397
The text was updated successfully, but these errors were encountered: