-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Will support for version 3 of the uptime monitor be made available? #8
Comments
Since i doesn't use the package anymore i have no testing environment for this. But PRs are welcome! |
my fork adds compatibility with v3 as well as pulling in both current PRs and improved exception handling I got from another fork |
@vesper8 if you want you could contribute this to this repo and get write access to it :) |
I don't know @LKaemmerling .. I've never maintained a public repo before.. totally unfamiliar with CI and how that works.. releases, tagging, and wouldn't even be sure whether these upgrades should go under a 3.0 version or stay on 2.0.. or how to even change that I could submit a PR with all the changes and you could approve it? That's all it needs and it'll be good for another year or more |
Yeah, this would be possible. If you want, i could show you everything which is needed for this :) OpenSource means teaching too :D |
I appreciate the generous offer. Even though I too have way too much on my plate at the moment, I'm inclined to agree, assuming it doesn't take too much of your time. How would we proceed? |
First of all you should create a PR with your changes :) I will review it then and add my comments about style, tests and so on there. |
No description provided.
The text was updated successfully, but these errors were encountered: