Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mint::Mesh unnecessarily requires coordinate arrays to be 2D (Nx1) arrays #1450

Open
gunney1 opened this issue Oct 17, 2024 · 1 comment
Open
Labels
low priority Mint Issues related to Axom's 'mint' component Reviewed

Comments

@gunney1
Copy link
Contributor

gunney1 commented Oct 17, 2024

There may be a real reason for the requirement, but it is in excess of the Blueprint mesh convention. The requirement may be related to storing the 1D arrays in MCArray, which is deprecated. Maybe we should store them as axom::Array and remove the 2D requirement. That is, if the change doesn't break anything.

@gunney1 gunney1 added the Mint Issues related to Axom's 'mint' component label Oct 17, 2024
@gunney1
Copy link
Contributor Author

gunney1 commented Nov 5, 2024

MR #1459 adds reshaping to sidre::View, so we can reshape the data to satisfy the mint::Mesh requirement. However, we may still want to consider removing the requirement if it is outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Mint Issues related to Axom's 'mint' component Reviewed
Projects
None yet
Development

No branches or pull requests

2 participants