Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to rearrange the items in my music #1282

Open
Blackfiction opened this issue Jan 5, 2025 · 6 comments
Open

Provide option to rearrange the items in my music #1282

Blackfiction opened this issue Jan 5, 2025 · 6 comments

Comments

@Blackfiction
Copy link
Contributor

Would it be a possibility to have some option in Lyrion to rearrange the menu items in the my music menu? Please see this post; https://forums.slimdevices.com/forum/user-forums/3rd-party-software/106269-announce-material-skin?p=1744214#post1744214

What determines the menu item order in the my music menu? For example, when I select my music, using material skin, I get the following order;
Artists
Bands
Artists (ex Classical) - this is an additional browse menu
Releases
etc...

Would't it be nice if the user can reorganize the menu items?

@michaelherger
Copy link
Member

Isn't this a Material skin setting? I'm not saying it was possible in Default, but if it's Material then you'd rather stick with that thread, or head over to the Material skin repository (https://github.com/CDrummond/lms-material).

@CDrummond
Copy link
Contributor

CDrummond commented Jan 6, 2025

The problem with implementing it in Material is that I don't store this list of items (unlike 'Home' screen), the contents come straight from LMS. So, if the user enables or disables items via LMS's settings then the correct list is shown.

LMS already assigns a weight to each item, which is used to define the order. If it was possible for a UI to alter the weight for an item then that could be used to implement this.

I must admit the current order, especially with user-defined roles, seems a bit random. Perhaps if user-defined roles were sorted alphabetically this would help? IMHO, a better order for this list would be a nicer solution than user-defined sort (and simpler to implement (well for me at least :) ). Perhaps:

  • Album Artists
  • All Artists
  • Artists
  • any other 'artist' based browse mode, sorted alphabetically
  • Albums
  • Random Albums
  • Compilations
  • New Music
  • Recently Updated Albums
  • any other 'albums' based browse mode, sorted alphabetically
  • Works
  • any other 'works' based browse mode, sorted alphabetically
  • Genres
  • Years
  • any other browse modes, sorted alphabetically

Then at least all 'artist' views are grouped together, and likewise for 'albums' based views. I could probably implement this all in Material, if this is not something you would like LMS to implement

@michaelherger
Copy link
Member

Thanks for the clarification @CDrummond. Right, that's not the main screen - I got that confused.

I like your suggestion about grouping by content type. I'd have to look how this could be implemented, as the current weight is numerical only, not content aware.

@Blackfiction
Copy link
Contributor Author

And would it be a possibility to let the user decide on the ordering in LMS settings? Default ordering could be as is or by content type.

@CDrummond
Copy link
Contributor

I'd go for it not being configurable. How is a new user supposed to choose between sorted (new order) and what the older order is - which they would never have seen. Not every little thing should be configurable, leads to a confusing mess.

@Blackfiction
Copy link
Contributor Author

I think the user can already choose his/her order when they have a SB Boom. So why not use that same screen/menu for the other players as well? When you go to LMS backend and select the Player there is a menu called Menu. which lets the user see all the menu items and there are arrows to move them up or down. Not sure why this menu is only available for SB Boom and not for SB Touch, SB Radio or squeelite devices?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants