From 2db12b9a047367bd05d627f9832ed44c5de339e1 Mon Sep 17 00:00:00 2001 From: Dan Lloyd Date: Wed, 4 Jan 2017 15:11:48 -0500 Subject: [PATCH] Raise exception on non-200 login requests Raise an exception for login failures rather than obtuse `KeyError: 'token'` --- mattermost_bot/mattermost.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mattermost_bot/mattermost.py b/mattermost_bot/mattermost.py index fef4746..24aae2e 100644 --- a/mattermost_bot/mattermost.py +++ b/mattermost_bot/mattermost.py @@ -43,9 +43,12 @@ def login(self, name, email, password): self.url + '/users/login', data=json.dumps(props), verify=self.ssl_verify ) - self.token = p.headers["Token"] - self.load_initial_data() - return json.loads(p.text) + if p.status_code == 200: + self.token = p.headers["Token"] + self.load_initial_data() + return json.loads(p.text) + else: + p.raise_for_status() def load_initial_data(self): self.initial = self.get('/users/initial_load')