Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogenize the config keyword that indicates file location #345

Closed
yymao opened this issue Jul 12, 2019 · 2 comments
Closed

Homogenize the config keyword that indicates file location #345

yymao opened this issue Jul 12, 2019 · 2 comments
Assignees
Labels
configs Issues related to catalog config yaml files priority:high

Comments

@yymao
Copy link
Member

yymao commented Jul 12, 2019

In an effort to make gcr-catalogs more easily installable outside NERSC (#271), we need to allow the root directory of file location to be configurable. The first step is to homogenize the config keyword that indicates file location.

Proposal:

Each catalog config that uses on-disk files must use base_dir to indicate the file location. Additional custom keywords can be used to indicate file names or file name patterns, but the catalog shall not access any file that does not sit in base_dir or its subdirectories.

@yymao yymao added the configs Issues related to catalog config yaml files label Jul 12, 2019
@yymao yymao self-assigned this Jul 12, 2019
@wmwv
Copy link
Contributor

wmwv commented Jul 14, 2019

I agree with the spirit of this. Which catalog configs currently don't obey this proposal?

But I would like this requirement to be on the catalog config files themselves, but not for the general behavior of specifying custom things in config_overwrite arguments when loading the catalog.

@yymao
Copy link
Member Author

yymao commented May 28, 2020

Superseded by #448

@yymao yymao closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configs Issues related to catalog config yaml files priority:high
Projects
None yet
Development

No branches or pull requests

2 participants