Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the project to Symfony 4.0 then to Symfony 4.2 #50

Closed
4 tasks done
Yann-BUTSCHER-EIRL opened this issue Jun 25, 2019 · 7 comments
Closed
4 tasks done

Upgrade the project to Symfony 4.0 then to Symfony 4.2 #50

Yann-BUTSCHER-EIRL opened this issue Jun 25, 2019 · 7 comments
Labels
Enhancement New feature or request

Comments

@Yann-BUTSCHER-EIRL
Copy link
Collaborator

Yann-BUTSCHER-EIRL commented Jun 25, 2019

Context

The differences between Symfony 3.4 and Symfony 4.0 are minor. The deprecated methods in 3.4 just desapear in 4.0 but otherwise the features are the same.

Then we should probably upgrade to 4.2 which is the next LTS version.

The faster we upgrade the project, the lesser code will need to be updated.

Todo

@Yann-BUTSCHER-EIRL Yann-BUTSCHER-EIRL added the Enhancement New feature or request label Jun 25, 2019
@Yann-BUTSCHER-EIRL Yann-BUTSCHER-EIRL changed the title Update the project to Symfont 4.0 then to Symfony 4.2 Update the project to Symfony 4.0 then to Symfony 4.2 Jun 25, 2019
@Yann-BUTSCHER-EIRL Yann-BUTSCHER-EIRL changed the title Update the project to Symfony 4.0 then to Symfony 4.2 Upgrade the project to Symfony 4.0 then to Symfony 4.2 Jun 25, 2019
Yann-BUTSCHER-EIRL added a commit that referenced this issue Jun 25, 2019
…ings during the tests, making them fail. It's also a first step toward removing deprecation warning in order to update the project to Symfony 4.0
@Yann-BUTSCHER-EIRL
Copy link
Collaborator Author

There is no more deprecation warnings when running the project so we could be able to transition to 4.0 easily

@LucileDT
Copy link
Member

Saw another interesting thing: we can show Symfony deprecation in unit tests, could you look at the official documentation?

@Yann-BUTSCHER-EIRL
Copy link
Collaborator Author

Yann-BUTSCHER-EIRL commented Jul 19, 2019

We already show them but there is no deprecation anymore.

After some testing I realized that we can't upgrade to 4.0 since Mink only support Symfony 2 and 3.
See this : minkphp/Mink#757

From this we have two obvious solutions :

  • Upgrade anyway and use something else than Mink for testing
  • Keeping the project in Symfony 3.4 for now

We might also try this : https://blog.rafalmuszynski.pl/how-to-configure-behat-with-symfony-4/
But I'm not sure if this will work

@Yann-BUTSCHER-EIRL
Copy link
Collaborator Author

Yann-BUTSCHER-EIRL commented Jul 24, 2019

The server has been upgraded in a new branch but there is thing we still need to do :

@LucileDT
Copy link
Member

I merged the branch on develop

Yann-BUTSCHER-EIRL added a commit that referenced this issue Jul 27, 2019
…generate a phpunit.xml file when first executing the script or when this file is missing.
Yann-BUTSCHER-EIRL added a commit that referenced this issue Aug 2, 2019
LucileDT added a commit that referenced this issue Aug 3, 2019
LucileDT added a commit that referenced this issue Aug 3, 2019
@LucileDT
Copy link
Member

LucileDT commented Dec 3, 2019

I think we should separate the todo list in several issues, this one is too big

@Yann-BUTSCHER-EIRL
Copy link
Collaborator Author

Closing this issue since all the remaining work has been exported to separated issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants