Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async support? #15

Open
lixiao-ibd opened this issue Nov 19, 2021 · 5 comments
Open

Async support? #15

lixiao-ibd opened this issue Nov 19, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@lixiao-ibd
Copy link

First of all, thank you for the great work!

Is your feature request related to a problem? Please describe.
I need to run some tasks in parallel, the repo sammchardy/python-binance supports this and it works well.
I am considering to switch to this repo(unicorn-binance-rest-api) because I am impressed by the unicorn-binance-websocket-api repo, and I see this repo is more active than sammchardy/python-binance.

Describe the solution you'd like
Anything similar to what sammchardy/python-binance does, it is well documented: https://sammchardy.github.io/async-binance-basics/

Describe alternatives you've considered
Well, continue to use sammchardy/python-binance for the async rest api and use this repo for the stream api

Additional context
None

@lixiao-ibd lixiao-ibd added the enhancement New feature or request label Nov 19, 2021
@oliver-zehentleitner
Copy link
Member

Hello!

Thanks for your interesst in this lib!

Its on the roadmap but will need a while!

You can mix with python binance, but we are not allways on the same versions of websockets, so sometimes its not easy to install both paralell, thats why i forked the rest api.

@oliver-zehentleitner
Copy link
Member

oliver-zehentleitner commented Mar 7, 2022

I think about how to implement asyncio support... a possible way is https://pypi.org/project/grequests/

https://code.luasoftware.com/tutorials/algo-trading/python-binance-asyncio-client/

@yarimiz
Copy link

yarimiz commented Oct 13, 2022

Hey @oliver-zehentleitner , any news regarding the async support for REST requests?

@oliver-zehentleitner
Copy link
Member

I will pick this up soon, need this then:
https://smarie.github.io/python-decopatch/

@daviduhm
Copy link

Can't wait for it! Thank you @oliver-zehentleitner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants