Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iframes incorrectly do not fire a load event if the site inside the iframe fails to load #3100

Open
1 task
skyz1 opened this issue Jan 2, 2025 · 1 comment
Labels
bug Something isn't working networking regression

Comments

@skyz1
Copy link
Contributor

skyz1 commented Jan 2, 2025

Summary

When the content of an iframe fails to load, the warning icon on the error page does not load. The load event is consequently not fired.

This issue was introduced in #2162, specifically d03f887. The request itself is successful, but the handlers for the success case are not called. The cause could be the implementation of readable_stream_pipe_to, but I'm not sure.

Operating system

macOS

Steps to reproduce

  1. Open http://wpt.live/x-frame-options/get-decode-split.html

Expected behavior

The warning icon shows up on the error pages in the iframes and the tests pass.

Actual behavior

The warning icon does not load and the test times out, because the load event does not fire.

URL for a reduced test case

N/A

HTML/SVG/etc. source for a reduced test case

<iframe src="./missing-file"></iframe>

Log output and (if possible) backtrace

N/A

Screenshots or screen recordings

No response

Build flags or config settings

No response

Contribute a patch?

  • I’ll contribute a patch for this myself.
@shannonbooth
Copy link
Contributor

Likely related (at least tangentially) to #2893

@AtkinsSJ AtkinsSJ added bug Something isn't working regression networking labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working networking regression
Projects
None yet
Development

No branches or pull requests

3 participants