Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operations for GCC builtin functions #32

Open
Lancern opened this issue Nov 19, 2024 · 2 comments
Open

Add operations for GCC builtin functions #32

Lancern opened this issue Nov 19, 2024 · 2 comments
Assignees
Labels
awaiting upstream Blocked by upstream issues dialect design The design of the MLIR dialect enhancement New feature or request
Milestone

Comments

@Lancern
Copy link
Owner

Lancern commented Nov 19, 2024

Similar to the LLVMIR dialect, we should provide dedicated operations for each GCC builtin function.

@Lancern Lancern added the enhancement New feature or request label Nov 19, 2024
@Lancern Lancern added this to the v0.1.0 initial release milestone Nov 19, 2024
@Lancern Lancern self-assigned this Nov 19, 2024
@SchrodingerZhu
Copy link
Collaborator

SchrodingerZhu commented Nov 19, 2024

Each is too much.

There are thousands of them and many of them are target specific. I think we should only consider most useful categories such as alloca/vector/overflow+arith/atomic.

For vector, we may also need to emit some always_inline functions to facilitate the translation, such as unaligned loading or reduce. Fortunately, rustc codegen project provides some examples there.

For aligned alloca and other stub builtins, we need to wait for upstream to update their support. See antoyo/libgccjit#5. I think we can release the first beta which can help us to push forward related patches in their IRC/ML.

@Lancern
Copy link
Owner Author

Lancern commented Nov 19, 2024

Each is too much.

OK, then we might cover those frequently used builtins first. LLVMIR dialect does not cover all LLVM intrinsics either.

Anyway let's remove this issue from the initial release milestone as this could be a long-term development process.

@Lancern Lancern removed this from the v0.1.0 initial release milestone Nov 19, 2024
@SchrodingerZhu SchrodingerZhu added this to the v0.0.2 milestone Nov 19, 2024
@SchrodingerZhu SchrodingerZhu added the awaiting upstream Blocked by upstream issues label Nov 19, 2024
@Lancern Lancern added the dialect design The design of the MLIR dialect label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting upstream Blocked by upstream issues dialect design The design of the MLIR dialect enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants