Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Clean Up #7

Open
5 tasks
SchrodingerZhu opened this issue Oct 24, 2024 · 1 comment
Open
5 tasks

Code Clean Up #7

SchrodingerZhu opened this issue Oct 24, 2024 · 1 comment

Comments

@SchrodingerZhu
Copy link
Collaborator

SchrodingerZhu commented Oct 24, 2024

I rushed to put all operations in but apparently there are some warnings and dirty code sections. Clean up is needed.

  • CI warnings
  • wrongly-documented operations
    %res = gccjit.call @foo ( %arg0 : !gccjit.int<i32>, %arg1 : !gccjit.int<i32> ) : !gccjit.int<i32>
  • parameter constraints in TableGen
  • Interface/traits to keep track of side effect or anything else commonly required by codegen
  • more....
@Lancern
Copy link
Owner

Lancern commented Oct 24, 2024

Another thing we need to start checking is putting parameter constraints in TableGen AMAP instead of checking these constraints manually in verifiers.

@Lancern Lancern added this to the v0.1.0 milestone Nov 19, 2024
@Lancern Lancern removed this from the v0.1.0 milestone Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants