Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fallbacks #15

Open
yak0d3 opened this issue Jan 21, 2019 · 2 comments
Open

Implement fallbacks #15

yak0d3 opened this issue Jan 21, 2019 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@yak0d3
Copy link
Member

yak0d3 commented Jan 21, 2019

This is mostly about how to treat exceptions, we are currently using a third party geo localization package. Sometimes requests might fail, and in that case an uncaught exception will be fired, which is not something good.
It will make somewhat a cool improvement if we get to look at the places where uncaught exceptions are and provide fallback methods; for example in case of failure of a [localization] request, the search will be made in an offline database that can be downloaded via a custom artisan command.

@yak0d3 yak0d3 added the help wanted Extra attention is needed label Jan 21, 2019
@yak0d3 yak0d3 changed the title Include fallbacks Implement fallbacks Jan 21, 2019
@axlon
Copy link
Contributor

axlon commented Jan 26, 2019

What do you think the behaviour should be if the underlying geo api fails?

@yak0d3
Copy link
Member Author

yak0d3 commented Jan 27, 2019

What do you think the behaviour should be if the underlying geo api fails?

I have already mentioned one behavior to consider in this part:

for example in case of failure of a [localization] request, the search will be made in an offline database that can be downloaded via a custom artisan command.

Of course, this should not be limited to the solution that i have proposed, there is always a room for creativity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants