Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11 Compatible Fork Is Here [INFO] #773

Open
fulopattila122 opened this issue Mar 12, 2024 · 9 comments
Open

Laravel 11 Compatible Fork Is Here [INFO] #773

fulopattila122 opened this issue Mar 12, 2024 · 9 comments

Comments

@fulopattila122
Copy link

fulopattila122 commented Mar 12, 2024

If anyone else like me is willing to win a few more months before replacing this package 😆 here's a drop-in replacement fork:

https://github.com/artkonekt/html

It supports Laravel 10 & 11; PHP 8.1 - 8.3. Other than that, the package, including the namespaces is unchanged.

Running this:

composer require konekt/html:^6.5

will replace the package and tell composer that it replaces laravelcollective/html which means the transition is seamless:

replacing the package

No further code changes are necessary.

@decadence
Copy link

decadence commented Mar 28, 2024

Thanks. Added a star to that repository. Hope it will be maintained.

@fulopattila122
Copy link
Author

Thanks. Added a star to that repository. Hope it will be maintained.

We've got quite a lot built on top of it, so the Laravel and PHP compatibility will be kept up to date.

@dramamask
Copy link

@fulopattila122 I'd be great is you could also allow phpunit 11. Laravel 11 uses phpunit 11.

@fulopattila122
Copy link
Author

@fulopattila122 I'd be great is you could also allow phpunit 11. Laravel 11 uses phpunit 11.

Laravel 11 internally allows either PHPUnit v10 or v11 see: https://github.com/laravel/framework/blob/11.x/composer.json#L112
so if you submit a PR, please keep both versions. Thx!

@rtconner
Copy link

Yeah I wish developers would learn from this.

If you are going to deprecate a package, be kind and modify the composer "require" to be as forgiving as possible.

@lorvent
Copy link

lorvent commented Sep 10, 2024

@fulopattila122 please enable issues in your repo aswell so people can post any issues they are facing.
basically a medium to exchange ideas, problems with you.

@arif98741
Copy link

I somehow created a fork version to support laravelcollective/html and found this one .
This fork version supports Laravel 10 and 11 . It also supports PHP ^8.1
xenon/laravelcollective-html

@fulopattila122
Copy link
Author

@fulopattila122 please enable issues in your repo aswell so people can post any issues they are facing. basically a medium to exchange ideas, problems with you.

I've enabled the discussions in the repo.

TBH, I'm reluctant to enable issues, since we don't really have the aim/bandwidth to add any new features. We only want to maintain the package as-is, keep the compatibility with Laravel 10, 11 and maybe later versions, and recent PHP versions.

I'm concerned that having the issues enabled would make people think that feature/change requests will be tackled.

@lorvent
Copy link

lorvent commented Sep 21, 2024

imo many people don't expect any feature enhancements at all,
just that we can report when a new laravel version is released etc.

also you can add a note in readme saying, if you want to see any new feature, simply send PR with all tests etc.
that way you can set expectations right for all the people :D

philippejadin added a commit to agorakit/agorakit that referenced this issue Nov 6, 2024
philippejadin added a commit to agorakit/agorakit that referenced this issue Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants